fix(roster): trust complete Cursor inventory - #601
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: escoffier-labs/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursor-agent modelsthrough a regular temporary file so Cursor does not cut the inventory at 8 KiB.Root cause
Cursor returned 8,844 bytes when stdout was a regular file but stopped at exactly 8,192 bytes when stdout was a pipe. Brigade used pipe capture and accepted the opening
Available modelsheader as proof that the truncated inventory was complete.The probe now validates Cursor stdout only, requires its closing
Tip:marker, and rejects malformed body rows before absence can be reported.Verification
pytest -q tests/test_model_inventory.py tests/test_roster_cmd.py tests/test_seat_health.pyexactfor bothkimi-k2.7-codeandglm-5.2-high../scripts/verify: 4,651 passed, 3 skipped; coverage 82.92%.Closes #596